Cannot clear default filter
-
Greg Schueler
the behavior is that no filters shows the local node only, versus previous behavior of no filters shows .*.
i don't think that "no filters" implies "all nodes" to everybody. so perhaps it's more of a UI issue...i.e. removing all filters should tell you beforehand that it will only show local node, and you have to be explicit about .* nodes to see all of them.
-
Alex-SF
I would like the behavior to be:
- Going to the Run page means a default Node listing showing the
rundeckserver with the filter preconfigured to be - "Name:
{rundeckserver}, Project:{selectedproject}"
- Pressing "Clear" in the filter form means remove the
{rundeckserver} from Name: and return listing of all nodes in the
project
- Clicking the "X" next to the "Name:" textfield meant match all nodes, equivalent to .* and is similar to #2 Allow the user to customize the emails generated by Rundeck
- Going to the Run page means a default Node listing showing the
rundeckserver with the filter preconfigured to be - "Name:
{rundeckserver}, Project:{selectedproject}"
-
Greg Schueler
- Milestone order changed from 17 to 0
That behavior is pretty confusing: having two different "default" filters when there is no filter set. Note that unset filter params is the same as pressing Clear.
I think we need to update the filter UI to explicitly support these common use cases: showing only server node, and showing all nodes. (in addition to: showing manually filtered set of nodes, or showing preset filter nodes.)
I'd suggest that we remove the "Clear" button since that is not (ahem) clear, and add buttons for "All Nodes" and "Server Node Only" in the short term.
so the new behavior would be:
- default filter (if unset) is name: {server node}
- user can press All Nodes, or Server Node or Filter button in the form
- user can select All Nodes, or Server Node or predefined filters from a drop down that is always shown.
-
Deleted User
You have a collection of nodes. By default, a filter is applied so a limited view of the entire collection is presented. Clearing that filter, by any means, produces all the resources (paged).
The bug is that clearing the filter produces a default filter when the absence of any filter needs to produce the entire collection.
A filter to show all nodes, is unnecessary.
-
Deleted User
Reading your original post. I think if you can explain: "i don't think that "no filters" implies "all nodes" to everybody." why this is true, it might help shed light on what your thinking.
Let me ask this way: What does "no filters" mean to you? You've indicated what it doesn't mean, but let us here the inverse.
-
Greg Schueler
Well i say that because the default behavior (now) of dispatch is that no node filters dispatches to local server node only. You have to be explicit about .* to include all nodes.
The conflict is that we want the default filter to be "show only server node", which is only applied if there is an absence of any filter...which you say should result in all nodes.
I don't know how you determine when "no filters" means "show only server node" and when it means "show all nodes", so I said we should have explicit buttons for them.
I take your point that "Filters" of any sort imply a restriction on the .* superset, so it seems like that should be the default, but that is not how we have done the default filter.
-
Deleted User
(from [2ef965fe3ed1b535ba7fdc656397ab0edef6d981]) Update node filter behavior [#190 Cannot clear default filter] https://github.com/dtolabs/rundeck/commit/2ef965fe3ed1b535ba7fdc656...
-
Greg Schueler
- State changed from new to resolved
-
Deleted User
(from [4cc5159393decdf615389ce28d20290f62b0afae]) Fix nodes embed view default behavior [#190 Cannot clear default filter] https://github.com/dtolabs/rundeck/commit/4cc5159393decdf615389ce28...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.