Customizable dispatch plugin

(from [95afe0e27d9265372fc4f4215af9a101ccfdad2d]) Initial plugin system and service refactor [#240 Customizable dispatch plugin ] https://github.com/dtolabs/rundeck/commit/95afe0e27d9265372fc4f4215...

I attempted to use script-exec to provide the closest OpenSSH analogue to the current behavior of the jsch plugin.

Using this resources.yaml:

centos5.local:
    hostname: centos5.local
    username: mlei
    node-executor: script-exec
    script-exec: ssh -o "StrictHostKeyChecking no" ${node.username}@${node.hostname} ${script-exec.command}

I get this message:

12:35:41 [null@centos5.local  1-exec][SEVERE] command-line: line 0: Bad configuration option: "StrictHostKeyChecking
12:35:41 [null@null null null][SEVERE] Execution failed on the following 1 nodes: {centos5.local=[Workflow results: {centos5.local=[[script-exec] success: false, result code: 255]}, failures: {centos5.local=[[script-exec] success: false, result code: 255]}: exception: com.dtolabs.rundeck.core.execution.workflow.WorkflowStepFailureException: Step 1 of the workflow failed with result: DispatcherResult{status=false, results={centos5.local=[script-exec] success: false, result code: 255}}]}

Some kind of argument splitting is happening here that shouldn't be...

With this resources.yaml:

centos5.local:
    hostname: centos5.local
    username: mlei
    node-executor: script-exec
    script-exec: ssh ${node.username}@${node.hostname} ${script-exec.command}

I get:

12:39:58 [null@centos5.local  1-exec][SEVERE] bash: exec.command: command not found
12:39:58 [null@null null null][SEVERE] Execution failed on the following 1 nodes: {centos5.local=[Workflow results: {centos5.local=[[script-exec] success: false, result code: 127]}, failures: {centos5.local=[[script-exec] success: false, result code: 127]}: exception: com.dtolabs.rundeck.core.execution.workflow.WorkflowStepFailureException: Step 1 of the workflow failed with result: DispatcherResult{status=false, results={centos5.local=[script-exec] success: false, result code: 127}}]}

Testing script-copy, this also failed:

centos5.local:
    hostname: centos5.local
    username: mlei
    node-executor: script-exec
    script-exec: ssh ${node.username}@${node.hostname} ${exec.command}
    file-copier: script-copy
    destdir: /tmp
    script-copy: scp ${file-copy.file} ${node.username}@${node.hostname}:${node.destdir}

This job fails with no output:

- id: 76b66d5d-cf68-406f-9159-341b1f120888
  project: test
  loglevel: INFO
  sequence:
    keepgoing: false
    strategy: node-first
    commands:
    - script: uname -a
  description: ''
  name: testjob2
  uuid: 76b66d5d-cf68-406f-9159-341b1f120888
  nodefilters:
    dispatch:
      threadcount: 1
      keepgoing: false
      excludePrecedence: true
    include:
      name: centos5.local

You can't even download the output of this execution, it gives you a 404.

(from [5df490b858d6cbbd354fb42fcf3cee20c499ae40]) Update documentation for script-exec plugin [#240 Customizable dispatch plugin ] https://github.com/dtolabs/rundeck/commit/5df490b858d6cbbd354fb42fc...

committed change to fix the no-output issue