Add node state attribute to resource model definition
-
Alex-SF- Milestone changed from Rundeck 1.0 to Rundeck 1.1
- Milestone order changed from 6 to 0
-
Alex-SF
- Milestone cleared.
- Milestone order changed from 1 to 0
-
Alex-SF
- Milestone set to Rundeck 1.2
- Milestone order changed from 12 to 0
-
Alex-SF
- Milestone changed from Rundeck 1.2 to Rundeck 1.3
- Milestone order changed from 1 to 0
-
Greg Schueler- Milestone order changed from 5 to 0
What name should this attribute have? "active"? or should we combine it with "state"?
The new plugin system/service architecture will make this easy to implement. The question is what should happen when...
e.g.:
if node attribute "active" has value "false" then: skip over the node completely and echo a message that the node has been skipped.
Is this the desired behavior?
-
Deleted UserWhy not punt on having rundeck do anything with the information? Just make sure it's passed to the dispatcher plugin and let it decide.
-
Greg Schueler
Well, I think this would be implemented at a higher level than the Node Executor (at the Command interpreter level). This would intercept any workflow command (script, exec, etc).
It also might be inconsistent/not applied depending on the particular node executor/file copier you are using. I think if we want to add this feature it should work consistently.
Better to bake this in at the higher level so it is reliable, (at least for the active/inactive behavior.)
Either way the same question then arises for our built in SSH/SCP implementations: what should the attribute be and what should the behavior be?
-
Deleted User
I don't think this ticket is about acting on the data...open another ticket for that feature. Just allow the ability to put it in the resource.xml and pass it along so it can be acted upon.
-
Greg Schueler
in that case it's already done due to resources allowing arbitrary attributes.
vote to mark resolved?
-
Deleted User
If it is passed through to the plugin then close it.
-
Greg Schueler
- State changed from new to resolved
node attributes are available to any node executor/file copier provider as part of #114 Refactor resource model definition and #240 Customizable dispatch plugin
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.