#190 ✓resolved
Noah Campbell

Cannot clear default filter

Reported by Noah Campbell | February 4th, 2011 @ 12:35 PM | in Rundeck 1.2

In the Run tab, I want to clear the default filter that shows only the server host. I click on the X next to name and click Filter. The filter is still applied.

The workaround is to put .* in Name to get all results.

My expectation is that no filters will show everything.

Comments and changes to this ticket

  • Greg Schueler

    Greg Schueler February 4th, 2011 @ 02:42 PM

    the behavior is that no filters shows the local node only, versus previous behavior of no filters shows .*.

    i don't think that "no filters" implies "all nodes" to everybody. so perhaps it's more of a UI issue...i.e. removing all filters should tell you beforehand that it will only show local node, and you have to be explicit about .* nodes to see all of them.

  • Alex-SF

    Alex-SF February 15th, 2011 @ 11:30 AM

    I would like the behavior to be:

    1. Going to the Run page means a default Node listing showing the rundeckserver with the filter preconfigured to be - "Name: {rundeckserver}, Project:{selectedproject}"
    2. Pressing "Clear" in the filter form means remove the {rundeckserver} from Name: and return listing of all nodes in the project
    3. Clicking the "X" next to the "Name:" textfield meant match all nodes, equivalent to .* and is similar to #2
  • Greg Schueler

    Greg Schueler February 17th, 2011 @ 09:49 AM

    • Milestone order changed from “17” to “0”

    That behavior is pretty confusing: having two different "default" filters when there is no filter set. Note that unset filter params is the same as pressing Clear.

    I think we need to update the filter UI to explicitly support these common use cases: showing only server node, and showing all nodes. (in addition to: showing manually filtered set of nodes, or showing preset filter nodes.)

    I'd suggest that we remove the "Clear" button since that is not (ahem) clear, and add buttons for "All Nodes" and "Server Node Only" in the short term.

    so the new behavior would be:

    • default filter (if unset) is name: {server node}
    • user can press All Nodes, or Server Node or Filter button in the form
    • user can select All Nodes, or Server Node or predefined filters from a drop down that is always shown.
  • Noah Campbell

    Noah Campbell February 17th, 2011 @ 10:07 AM

    You have a collection of nodes. By default, a filter is applied so a limited view of the entire collection is presented. Clearing that filter, by any means, produces all the resources (paged).

    The bug is that clearing the filter produces a default filter when the absence of any filter needs to produce the entire collection.

    A filter to show all nodes, is unnecessary.

  • Noah Campbell

    Noah Campbell February 17th, 2011 @ 10:11 AM

    Reading your original post. I think if you can explain: "i don't think that "no filters" implies "all nodes" to everybody." why this is true, it might help shed light on what your thinking.

    Let me ask this way: What does "no filters" mean to you? You've indicated what it doesn't mean, but let us here the inverse.

  • Greg Schueler

    Greg Schueler February 17th, 2011 @ 10:26 AM

    Well i say that because the default behavior (now) of dispatch is that no node filters dispatches to local server node only. You have to be explicit about .* to include all nodes.

    The conflict is that we want the default filter to be "show only server node", which is only applied if there is an absence of any filter...which you say should result in all nodes.

    I don't know how you determine when "no filters" means "show only server node" and when it means "show all nodes", so I said we should have explicit buttons for them.

    I take your point that "Filters" of any sort imply a restriction on the .* superset, so it seems like that should be the default, but that is not how we have done the default filter.

  • Noah Campbell
  • Greg Schueler

    Greg Schueler February 21st, 2011 @ 10:57 AM

    • State changed from “new” to “resolved”
  • Noah Campbell

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

(DEPRECATED) Please use github issues for issue tracking at http://github.com/dtolabs/rundeck/issues

Shared Ticket Bins

People watching this ticket

Referenced by

Pages